[Spice-devel] [PATCH spice-server] red-record-qxl: Remove potential leak

Christophe Fergeau cfergeau at redhat.com
Tue Jun 26 10:13:57 UTC 2018


Acked-by: Christophe Fergeau <cfergeau at redhat.com>

On Mon, Jun 25, 2018 at 11:46:22AM +0100, Frediano Ziglio wrote:
> On some systems you need to call g_spawn_close_pid after
> spawning a process to avoid leaks (currently Windows).
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/red-record-qxl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/server/red-record-qxl.c b/server/red-record-qxl.c
> index 0065fc45..974963b0 100644
> --- a/server/red-record-qxl.c
> +++ b/server/red-record-qxl.c
> @@ -905,6 +905,7 @@ RedRecord *red_record_new(const char *filename)
>              continue;
>          }
>          close(fd_in);
> +        g_spawn_close_pid(child_pid);
>      }
>  
>      if (fwrite(header, sizeof(header)-1, 1, f) != 1) {
> -- 
> 2.17.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180626/3b46348b/attachment.sig>


More information about the Spice-devel mailing list