[Spice-devel] [PATCH spice-streaming-agent v2 0/9] More refactor and separation
Lukáš Hrázký
lhrazky at redhat.com
Tue Jun 26 11:50:44 UTC 2018
I'm still not happy about the frame log.
Changes since v1:
- Merged acked patches.
- Added a patch improving the logged messages in the frame log.
- Use nullptr instead of NULL.
- Removed a spurious linebreak change.
- Extended the description for the std::chrono patch.
- Fixed a patch not compiling.
- Separated moving the register_interrupts() call into a separate patch.
- Added a patch removing '\n' from all syslog() calls.
Lukáš Hrázký (9):
Separate the code for logging frames/times into a class
Improve the frame log messages
FrameLog: Use std::chrono instead of gettimeofday for time
Introduce a short class to have RAII on the syslog
Make the try-catch block in main() a catch-all
Clean up the global try-catch block
Move register_interrupts() before the try-catch block
Move out the cursor-updating code into it's own class
Remove unnecessary '\n' in syslog calls
src/Makefile.am | 4 +
src/cursor-updater.cpp | 106 +++++++++++++++++
src/cursor-updater.hpp | 34 ++++++
src/frame-log.cpp | 74 ++++++++++++
src/frame-log.hpp | 39 +++++++
src/mjpeg-fallback.cpp | 2 +-
src/spice-streaming-agent.cpp | 208 +++++++++-------------------------
7 files changed, 310 insertions(+), 157 deletions(-)
create mode 100644 src/cursor-updater.cpp
create mode 100644 src/cursor-updater.hpp
create mode 100644 src/frame-log.cpp
create mode 100644 src/frame-log.hpp
--
2.17.1
More information about the Spice-devel
mailing list