[Spice-devel] [PATCH spice-server 1/3] Add support for building with meson

[Christophe Fergeau]

On Mon, Jun 18, 2018 at 12:04:18PM -0400, Frediano Ziglio wrote:
> Not much replies to this specific patch, but I agree was better to
> integrate dependencies (spice-protocol and spice-common) projects
> first.
> 

> > diff --git a/subprojects/spice-common.wrap b/subprojects/spice-common.wrap
> > new file mode 100644
> > index 00000000..6117c631
> > --- /dev/null
> > +++ b/subprojects/spice-common.wrap
> > @@ -0,0 +1,4 @@
> > +[wrap-git]
> > +directory=spice-common
> > +url=https://gitlab.com/etrunko/spice-common.git
> > +revision=meson
> 
> Don't like much the full URL. Is it not possible to have something
> relative to the current one?
> Also, does this points just to master? Would be a regression to
> current autoconf/submodule behaviour.

This is one part of the patch which imo does not make sense without
autotools removal (autotools build -> spice-common/ submodule, meson build ->
meson-specific subprojects/spice-common/ through this .wrap file). I've
already sent a patch to avoid this to Eduardo, so I'm expecting at some
point an updated patch with this change, and probably a few more smaller
ones.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180626/d27b0e13/attachment.sig>