[Spice-devel] [PATCH spice-streaming-agent v2 7/9] Move register_interrupts() before the try-catch block
Frediano Ziglio
fziglio at redhat.com
Wed Jun 27 14:24:31 UTC 2018
>
> It doesn't throw and is part of the main() setup, not the business code.
>
> Signed-off-by: Lukáš Hrázký <lhrazky at redhat.com>
> ---
> src/spice-streaming-agent.cpp | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
> index ea4d4fd..0a23eb0 100644
> --- a/src/spice-streaming-agent.cpp
> +++ b/src/spice-streaming-agent.cpp
> @@ -474,14 +474,14 @@ int main(int argc, char* argv[])
> }
> }
>
> + register_interrupts();
> +
> try {
> // register built-in plugins
> MjpegPlugin::Register(&agent);
>
> agent.LoadPlugins(pluginsdir);
>
> - register_interrupts();
> -
> FrameLog frame_log(log_filename, log_binary, log_frames);
>
> for (const std::string& arg: old_args) {
Not that not throwing is a big reason to put a function outside a try {} catch {}.
Otherwise,
Acked-by: Frediano Ziglio <fziglio at redhat.com>
Frediano
More information about the Spice-devel
mailing list