[Spice-devel] [spice-server 4/4] qxl: Remove red_channel_printerr()

Christophe Fergeau cfergeau at redhat.com
Thu Jun 28 11:54:16 UTC 2018


It was only used twice, for what looks like adhoc debugging. This commit
removes it, similarly to what was done for some spice_printerr() calls.
---
 server/red-channel.h | 3 ---
 server/red-qxl.c     | 4 ----
 2 files changed, 7 deletions(-)

diff --git a/server/red-channel.h b/server/red-channel.h
index 4e7a9066e..ad446e609 100644
--- a/server/red-channel.h
+++ b/server/red-channel.h
@@ -232,9 +232,6 @@ void red_channel_disconnect_client(RedChannel *channel, RedChannelClient *rcc);
                         id_, channel_, ## __VA_ARGS__);                                  \
     } while (0)
 
-#define red_channel_printerr(channel, format, ...)                                       \
-        red_channel_log_generic(spice_printerr, channel, format, ## __VA_ARGS__);
-
 #define red_channel_warning(channel, format, ...)                                        \
         red_channel_log_generic(g_warning, channel, format, ## __VA_ARGS__);
 
diff --git a/server/red-qxl.c b/server/red-qxl.c
index ac7b10a17..854d019b8 100644
--- a/server/red-qxl.c
+++ b/server/red-qxl.c
@@ -114,8 +114,6 @@ static void red_qxl_display_migrate(RedChannelClient *rcc)
     Dispatcher *dispatcher;
     RedChannel *channel = red_channel_client_get_channel(rcc);
 
-    red_channel_printerr(channel, "");
-
     dispatcher = (Dispatcher *)g_object_get_data(G_OBJECT(channel), "dispatcher");
     payload.rcc = g_object_ref(rcc);
     dispatcher_send_message(dispatcher,
@@ -161,8 +159,6 @@ static void red_qxl_cursor_migrate(RedChannelClient *rcc)
     Dispatcher *dispatcher;
     RedChannel *channel = red_channel_client_get_channel(rcc);
 
-    red_channel_printerr(channel, "");
-
     dispatcher = (Dispatcher *)g_object_get_data(G_OBJECT(channel), "dispatcher");
     payload.rcc = g_object_ref(rcc);
     dispatcher_send_message(dispatcher,
-- 
2.17.1



More information about the Spice-devel mailing list