[Spice-devel] [PATCH spice-gtk] Replace spice_printerr() with g_warning()

Frediano Ziglio fziglio at redhat.com
Thu Jun 28 15:38:21 UTC 2018


The remaining occurrences of spice_printerr() are warnings when
something unexpected happens, they can be replaced with g_warning() so
that users of spice-server can redirect them with
g_log_set_default_handler().

Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
---
 src/channel-display.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

I know... I'm so lazy I didn't even came out with my
own commit message...

diff --git a/src/channel-display.c b/src/channel-display.c
index 8fb4dee9..44ba0439 100644
--- a/src/channel-display.c
+++ b/src/channel-display.c
@@ -1211,7 +1211,7 @@ static void report_invalid_stream(SpiceChannel *channel, uint32_t id)
         /* Send a special stream report (UINT_MAX dropped frames out of zero)
          * to indicate there is no such stream.
          */
-        spice_printerr("notify the server that stream %u does not exist", id);
+        g_warning("notify the server that stream %u does not exist", id);
         memset(&report, 0, sizeof(report));
         report.stream_id = id;
         report.num_frames = 0;
@@ -1269,7 +1269,7 @@ static display_stream *display_stream_create(SpiceChannel *channel,
         break;
     }
     if (st->video_decoder == NULL) {
-        spice_printerr("could not create a video decoder for codec %u", codec_type);
+        g_warning("could not create a video decoder for codec %u", codec_type);
         g_clear_pointer(&st, display_stream_destroy);
     }
     return st;
@@ -1310,7 +1310,7 @@ static void display_handle_stream_create(SpiceChannel *channel, SpiceMsgIn *in)
                                                op->flags, op->codec_type,
                                                &op->dest, &op->clip);
     if (c->streams[op->id] == NULL) {
-        spice_printerr("could not create the %u video stream", op->id);
+        g_warning("could not create the %u video stream", op->id);
         destroy_stream(channel, op->id);
         report_invalid_stream(channel, op->id);
     }
-- 
2.17.1



More information about the Spice-devel mailing list