[Spice-devel] [PATCH spice-common] log: Remove spice_printerr macro

Christophe Fergeau cfergeau at redhat.com
Fri Jun 29 15:41:56 UTC 2018


Once the spice-gtk patch is in,
Acked-by: Christophe Fergeau <cfergeau at redhat.com>

On Thu, Jun 28, 2018 at 04:42:25PM +0100, Frediano Ziglio wrote:
> All usages of this macro were removed.
> A library should not log to standard error but use log facilities
> so remove this macro to avoid possible future usage.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  common/log.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/common/log.h b/common/log.h
> index e0fd34b..74b3806 100644
> --- a/common/log.h
> +++ b/common/log.h
> @@ -57,10 +57,6 @@ void spice_log(GLogLevelFlags log_level,
>      spice_log(G_LOG_LEVEL_WARNING, SPICE_STRLOC, __FUNCTION__, "should not be reached"); \
>  } G_STMT_END
>  
> -#define spice_printerr(format, ...) G_STMT_START {                      \
> -    fprintf(stderr, "%s: " format "\n", __FUNCTION__, ## __VA_ARGS__);  \
> -} G_STMT_END
> -
>  #define spice_info(format, ...) G_STMT_START {                         \
>      spice_log(G_LOG_LEVEL_INFO, SPICE_STRLOC, __FUNCTION__, "" format, ## __VA_ARGS__); \
>  } G_STMT_END
> -- 
> 2.17.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180629/0b59ac2f/attachment.sig>


More information about the Spice-devel mailing list