[Spice-devel] [spice-server PATCH] stream_device_partial_read: check once if whole hdr is read

Uri Lublin uril at redhat.com
Mon Mar 5 16:21:31 UTC 2018


On 03/05/2018 06:01 PM, Frediano Ziglio wrote:
>>
>> The "read header" loop checks if the whole header is read twice:
>> once in the while condition and once in the end of the loop body.
>>
>> This patch removes the latter check and sets appropriate variables
>> outside of the loop.
>>
>> Signed-off-by: Uri Lublin <uril at redhat.com>
> 
> This patch does not pass "make check".
> The reason is that that code is executed multiple time for the
> same message if the message is send using multiple send.

You are correct. The second if should stay inside the loop so it
happens once for every message.


More information about the Spice-devel mailing list