[Spice-devel] [spice-server v3] reds: Close sockets when failing to watch them

[Christophe Fergeau]

On Thu, Mar 08, 2018 at 03:54:56PM +0200, Uri Lublin wrote:
> On 03/08/2018 03:23 PM, Christophe Fergeau wrote:
> > Currently if we fail to set up the watch waiting for accept() to be
> > called on the socket, we still keep the network socket(s) open even if we
> > are not going to be able to use it. This commit makes sure it's closed a
> > set to -1 when such a failure occurs rather than having a half
> > initialized spice-server instance.
> 
> Ack.
> 
> I see below you removed some log-messages.
> Perhaps it would be better to just change their messages.

I'll add squash it back, though in general, I think spice-server tends
to be too verbose, which is why I tried to kill that one without telling
anyone ;)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180309/bfa7b801/attachment.sig>