[Spice-devel] [PATCH spice-streaming-agent 1/2] Add name to an unnamed structure

[Lukáš Hrázký]

On Fri, 2018-03-09 at 07:35 +0000, Frediano Ziglio wrote:
> Unnamed structure combined with inheritance is considered a
> bit hard to read, add a name to make more readable.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  src/spice-streaming-agent.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
> index b39782c..37addf4 100644
> --- a/src/spice-streaming-agent.cpp
> +++ b/src/spice-streaming-agent.cpp
> @@ -145,7 +145,7 @@ static void handle_stream_error(size_t len)
>                                   std::to_string(sizeof(StreamMsgNotifyError)) + ")");
>      }
>  
> -    struct : StreamMsgNotifyError {
> +    struct NotifyError : StreamMsgNotifyError {

No replies... FWIW, if to name it, I would pick something like
StreamMsgNotifyError1K to indicate it's here because we specify the
size. But at this point it's just bike-shedding. :)

Lukas

>          uint8_t msg[1024];
>      } msg;
>