[Spice-devel] [PATCH spice-streaming-agent 1/1] rename the virtio port to com.redhat.spice.stream.0

[Daniel P. Berrangé]

On Fri, Mar 23, 2018 at 02:22:23PM +0100, Christophe de Dinechin wrote:
> 
> 
> > On 23 Mar 2018, at 13:52, Lukáš Hrázký <lhrazky at redhat.com> wrote:
> > 
> > On Fri, 2018-03-23 at 13:41 +0100, Christophe de Dinechin wrote:
> >>> On 23 Mar 2018, at 13:36, Lukáš Hrázký <lhrazky at redhat.com> wrote:
> >>> 
> >>> On Fri, 2018-03-23 at 12:00 +0100, Christophe de Dinechin wrote:
> >>>>> On 22 Mar 2018, at 14:13, Lukáš Hrázký <lhrazky at redhat.com> wrote:
> >>>>> 
> >>>>> The name "com.redhat.stream.0" is too generic and in no way denotes it
> >>>>> belongs to SPICE.
> >>>> 
> >>>> This also would need to be sync’d with libvirt and virt-manager, no? I’ve not checked how Boxes does it.
> >>>> 
> >>>>   <channel type='unix'>
> >>>>     <target type='virtio' name='org.qemu.guest_agent.0'/>
> >>>>     <address type='virtio-serial' controller='0' bus='0' port='1'/>
> >>>>   </channel>
> >>>>   <channel type='spicevmc'>
> >>>>     <target type='virtio' name='com.redhat.spice.0'/>
> >>>>     <address type='virtio-serial' controller='0' bus='0' port='2'/>
> >>>>   </channel>
> >>>>   <channel type='spiceport'>
> >>>>     <source channel='com.redhat.stream.0'/>
> >>>>     <target type='virtio' name='com.redhat.stream.0'/>
> >>>>     <address type='virtio-serial' controller='0' bus='0' port='3'/>
> >>>>   </channel>
> >>> 
> >>> Where is this XML excerpt coming from?
> >> 
> >> virsh edit <machine-name>
> > 
> > Ok, and you've put the "com.redhat.stream.0" yourself, I think?
> 
> Well, that’s a choice that virt-manager provides by default in the selection
> menu. I could have changed it (only at creation time as I mentioned), but
> the defaults are provided by libvirt or virt-manager (not sure, I’ve not
> looked into it).
> 
> 
> > If not,
> > I've missed something somewhere, but I would guess it has to be in
> > libvirt and I haven't found it there.
> > 
> > I suppose we'll want to add it to libvirt eventually, and better sort
> > out the name for it before we do :)
> 
> Yes. Daniel might help us following the correct procedure there, and maybe
> provide naming guidelines too.

The convention recommended is to use the domain name associated with the
project if it has one, add some project specific suffix.

So SPICE should really be using  org.spice-space, not com.redhat

We can't change any existing names though without causing back compatibility
problems with existing deployed OS.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|