[Spice-devel] [PATCH spice-streaming-agent 1/1] rename the virtio port to com.redhat.spice.stream.0

[Lukáš Hrázký]

On Fri, 2018-03-23 at 12:00 -0400, Frediano Ziglio wrote:
> > On Fri, 2018-03-23 at 14:22 +0100, Christophe de Dinechin wrote:
> > > > On 23 Mar 2018, at 13:52, Lukáš Hrázký <lhrazky at redhat.com> wrote:
> > > > 
> > > > On Fri, 2018-03-23 at 13:41 +0100, Christophe de Dinechin wrote:
> > > > > > On 23 Mar 2018, at 13:36, Lukáš Hrázký <lhrazky at redhat.com> wrote:
> > > > > > 
> > > > > > On Fri, 2018-03-23 at 12:00 +0100, Christophe de Dinechin wrote:
> > > > > > > > On 22 Mar 2018, at 14:13, Lukáš Hrázký <lhrazky at redhat.com>
> > > > > > > > wrote:
> > > > > > > > 
> > > > > > > > The name "com.redhat.stream.0" is too generic and in no way
> > > > > > > > denotes it
> > > > > > > > belongs to SPICE.
> > > > > > > 
> > > > > > > This also would need to be sync’d with libvirt and virt-manager,
> > > > > > > no? I’ve not checked how Boxes does it.
> > > > > > > 
> > > > > > >   <channel type='unix'>
> > > > > > >     <target type='virtio' name='org.qemu.guest_agent.0'/>
> > > > > > >     <address type='virtio-serial' controller='0' bus='0' port='1'/>
> > > > > > >   </channel>
> > > > > > >   <channel type='spicevmc'>
> > > > > > >     <target type='virtio' name='com.redhat.spice.0'/>
> > > > > > >     <address type='virtio-serial' controller='0' bus='0' port='2'/>
> > > > > > >   </channel>
> > > > > > >   <channel type='spiceport'>
> > > > > > >     <source channel='com.redhat.stream.0'/>
> > > > > > >     <target type='virtio' name='com.redhat.stream.0'/>
> > > > > > >     <address type='virtio-serial' controller='0' bus='0' port='3'/>
> > > > > > >   </channel>
> > > > > > 
> > > > > > Where is this XML excerpt coming from?
> > > > > 
> > > > > virsh edit <machine-name>
> > > > 
> > > > Ok, and you've put the "com.redhat.stream.0" yourself, I think?
> > > 
> > > Well, that’s a choice that virt-manager provides by default in the
> > > selection menu. I could have changed it (only at creation time as I
> > > mentioned), but the defaults are provided by libvirt or virt-manager (not
> > > sure, I’ve not looked into it).
> > 
> > Is it in "Add Hardware" -> "Channel"? I don't have the
> > "com.redhat.stream.0" option myself. What version of libvirt and on
> > what OS? I'm on Gentoo. As I said, I haven't found
> > "com.redhat.stream.0" in libvirt sources, while "com.redhat.spice.0" is
> > there (so that's where I expect it to be, also checked virt-manager).
> > So unless it was patched in by packaging (which I find weird too), I
> > have no idea where it's coming from.
> > 
> 
> If you choose spice port you can change the name as you want and add the
> "com.redhat.stream.0" (or whatever name you like).

Yeah, I've realized that later, so maybe that's what Christophe did.

> ...
> 
> Frediano