[Spice-devel] [PATCH spice-server 1/2] Add support for building with meson

[Eduardo Lima (Etrunko)]

On 27/03/18 07:26, Christophe Fergeau wrote:
> Couple of notes for people trying this,
> 
> On Thu, Mar 22, 2018 at 02:18:20PM -0300, Eduardo Lima (Etrunko) wrote:
>> diff --git a/meson.build b/meson.build
>> new file mode 100644
>> index 00000000..f373e662
>> --- /dev/null
>> +++ b/meson.build
>> @@ -0,0 +1,175 @@
>> +#
>> +# project definition
>> +#
>> +# TODO: double check meson.project_version()
>> +# Ideally we would use the output of git-version-gen as input for meson, because
>> +# we can not check the result of the command before declaring project().
>> +#
>> +project('spice', 'c',
>> +         version : run_command('build-aux/git-version-gen', '.tarball-version').stdout().strip(),
>> +         license : 'LGPLv2.1',
>> +         meson_version : '>= 0.45.0')
> 
> meson 0.45 is needed, I was getting weird errors with 0.44.1 on my
> Fedora 27. Upgrading to 0.45 which is available in updates-testing made
> them go away.
> 

Yes, in the cover message I explained how to upgrade meson using python
pip, good to know that the package has made it to updates-testing already.

>> diff --git a/subprojects/spice-common.wrap b/subprojects/spice-common.wrap
>> new file mode 100644
>> index 00000000..6117c631
>> --- /dev/null
>> +++ b/subprojects/spice-common.wrap
>> @@ -0,0 +1,4 @@
>> +[wrap-git]
>> +directory=spice-common
>> +url=https://gitlab.com/etrunko/spice-common.git
>> +revision=meson
> 
> Have you tried just putting a symlink to the top-level spice-server in
> subprojects/ and not having this spice-common.wrap file at all?
> 

No, I think it should work, but this .wrap file is useful the first time
user clones the repository, it will fetch spice-common automatically.


-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com