[Spice-devel] [spice-gtk 2/3] usb: Remove unused spice_marshaller_add_by_ref_full() user data

Frediano Ziglio fziglio at redhat.com
Fri May 4 14:02:43 UTC 2018


> 
> g_free() only expects a single argument, so it won't make use of the
> extra 'channel' arg which will be passed as user data.
> ---
>  src/channel-usbredir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c
> index f509e49d..0cc56306 100644
> --- a/src/channel-usbredir.c
> +++ b/src/channel-usbredir.c
> @@ -712,7 +712,7 @@ static int try_write_compress_LZ4(SpiceUsbredirChannel
> *channel, uint8_t *data,
>                                           compressed_data_msg.compressed_data,
>                                           compressed_data_count,
>                                           (spice_marshaller_item_free_func)g_free,
> -                                         channel);
> +                                         NULL);
>          spice_msg_out_send(msg_out_compressed);
>          return TRUE;
>      }

Acked-by: Frediano Ziglio <fziglio at redhat.com>

Frediano


More information about the Spice-devel mailing list