[Spice-devel] [PATCH spice-common] codegen: Removed unused get_type methods

[Frediano Ziglio]

> 
> On Sun, 2018-05-06 at 13:29 +0100, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > ---
> >  python_modules/ptypes.py | 9 ---------
> >  1 file changed, 9 deletions(-)
> > 
> > diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py
> > index d29c97a..209c00e 100644
> > --- a/python_modules/ptypes.py
> > +++ b/python_modules/ptypes.py
> > @@ -145,9 +145,6 @@ class Type:
> >      def has_name(self):
> >          return self.name != None
> >  
> > -    def get_type(self, recursive=False):
> > -        return self
> > -
> >      def is_primitive(self):
> >          return False
> >  
> > @@ -256,12 +253,6 @@ class TypeAlias(Type):
> >          self.the_type = the_type
> >          self.attributes = fix_attributes(attribute_list)
> >  
> > -    def get_type(self, recursive=False):
> > -        if recursive:
> > -            return self.the_type.get_type(True)
> > -        else:
> > -            return self.the_type
> > -
> >      def primitive_type(self):
> >          return self.the_type.primitive_type()
> 
> It seems these methods might be there for "API completeness" of the
> classes and therefore perhaps better to keep them there (though I
> didn't really go and see how much sense it makes). But if you insist,
> 
> Acked-by: Lukáš Hrázký <lhrazky at redhat.com>
> 
> (might also wanna wait a bit to see if someone holds special feelings
> for them :))
> 

I found confusing that a Type class has a "get_type" method :-)
Looking around looks like this maybe was replaced by "resolve" method
which find the right concrete type.

Frediano