[Spice-devel] [spice-gtk] build-sys: Update gettext 0.18.2 -> 0.19.8

[Victor Toso]

Hey,

On Tue, May 15, 2018 at 12:49:53AM -0400, Frediano Ziglio wrote:
> > 
> > From: Victor Toso <me at victortoso.com>
> > 
> > It was bumped to 0.19.0 by:
> > 
> >     commit 6195151f943480eecf38029ffad8a86844406659
> >     Author: Marc-André Lureau <marcandre.lureau at redhat.com>
> >     Date:   Tue Mar 28 14:51:04 2017 +0200
> > 
> >     build-sys: modernize gettext
> >     (...)
> > 
> > And then got downgraded to 0.18.2 by:
> > 
> >     commit 20f717dac0962c2c52d0f17ba50556eb5aeffb0f
> >     Author: Christophe Fergeau <cfergeau at redhat.com>
> >     Date:   Mon Jul 17 13:21:01 2017 +0200
> > 
> >     build-sys: Lower gettext requirement
> > 
> >     spice-gtk currently requires gettext 0.19 which is a fairly
> >     recent release (not available in el7.3 and older, nor in
> >     ubuntu 14.04 LTS).  They both have a gettext newer than
> >     0.18.2, so we can require that.
> > 
> >     Requiring 0.18 or 0.18.1 is throwing automake errors because
> >     of our use of -Werror, so we side-step this by requiring
> >     0.18.2.
> > 
> > The 0.19 release is quite stable for a while now. Since RHEL 7.4
> > we have 0.19.8 which this patch tries to have as well.
> > 
> > 0.19.8 was part of Fedora 25, considering that we are on Fedora
> > 28, I hope its not a problem to bump this.
> > 
> > Signed-off-by: Victor Toso <victortoso at redhat.com>
> > ---
> >  configure.ac | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index a9a7eb9..04dd8cb 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -16,7 +16,7 @@ AM_MAINTAINER_MODE
> >  GETTEXT_PACKAGE=AC_PACKAGE_TARNAME
> >  AC_SUBST(GETTEXT_PACKAGE)
> >  AC_DEFINE_UNQUOTED([GETTEXT_PACKAGE], "$GETTEXT_PACKAGE", [GETTEXT package
> >  name])
> > -AM_GNU_GETTEXT_VERSION([0.18.2])
> > +AM_GNU_GETTEXT_VERSION([0.19.8])
> >  AM_GNU_GETTEXT([external])
> >
> >
>
> I miss the point. Why requiring a more recent version if we don't use
> any new feature?

I got interested in adding the git history to commit log that I
forgot to add why the change. Sorry about that.

Reason is nothing new that I personally want from gettext but a
build issue while using jhbuild. The error:

make[3]: Leaving directory '/home/toso/.cache/jhbuild/build/spice-gtk/po'
*** error: gettext infrastructure mismatch: using a Makefile.in.in from
    gettext version 0.18 but the autoconf macros are from gettext version 0.19

Not sure when this incompatibility started from jhbuild/gettext
as I don't update jhbuild binary often. Instead of trying to
check the build tool I thought it would be fair to update the
gettext dependency in spice-gtk.

> The spice-gtk will pick up the new version if installed.
> Looks like this patch only will fail to compile if you have an older version
> despite it can work. Marc-Andre patch removed intltool usage as broken but
> increasing the requirement too much while Christophe tested with a former
> version still providing needed feature.
> I upgraded to Ubuntu 18.04 LTS really recently, I suppose people will still
> be using 14.04 LTS for a little longer.

Right, not really a big deal. I'll check how to fix from jhbuild
later on (probably adding a gettext 0.18.3 dependency that will
be downloaded/build and spice-gtk will use that, etc.)

Cheers,
        toso
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180515/4064a34f/attachment.sig>