[Spice-devel] [PATCH spice-gtk] Gstreamer: Don't let overlay to handle windowing system events

[Snir Sheriber]

Hi,


On 05/16/2018 05:16 PM, Frediano Ziglio wrote:
>> In case glimagesink is used (up to playbin) window system events
>> do not propagate to the widget. This patch tells the overlay not
>> to try handle window system events.
>>
> Which event? Did you had any issue? Kind of moving mouse/pressing keyboard
> I suppose

Yes, i didn't get mouse motion events, when pipeline was using the nvdec 
decoder, but it may
happen in other cases too (more likely when decoder's output supports 
GlMemory).


>
>> Signed-off-by: Snir Sheriber <ssheribe at redhat.com>
>> ---
>>   src/channel-display-gst.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
>> index 3d0827a..9bc9f50 100644
>> --- a/src/channel-display-gst.c
>> +++ b/src/channel-display-gst.c
>> @@ -318,6 +318,7 @@ static gboolean handle_pipeline_message(GstBus *bus,
>> GstMessage *msg, gpointer v
>>               if (decoder->win_handle != 0) {
>>                   overlay = GST_VIDEO_OVERLAY(GST_MESSAGE_SRC(msg));
>>                   gst_video_overlay_set_window_handle(overlay,
>>                   decoder->win_handle);
>> +                gst_video_overlay_handle_events (overlay, false);
> Style: space before arguments.
ok

Thanks, Snir.

>>               }
>>           }
>>           break;
> Frediano

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Gstreamer-Don-t-let-overlay-to-handle-windowing-syst.patch
Type: text/x-patch
Size: 1101 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180516/61cf2d3e/attachment.bin>