[Spice-devel] [PATCH spice-common 3/4] Check for messages with duplicate names inside a channel

[Frediano Ziglio]

> 
> On Mon, May 14, 2018 at 11:18:53PM +0100, Frediano Ziglio wrote:
> > Make sure there are not 2 messages with the same name in the
> > same channel.
> > 
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > ---
> >  python_modules/ptypes.py | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py
> > index ef580aa..664dd1d 100644
> > --- a/python_modules/ptypes.py
> > +++ b/python_modules/ptypes.py
> > @@ -1055,6 +1055,9 @@ class ChannelType(Type):
> >                      m.value = info.count
> >                  info.count = m.value + 1
> >                  info.messages.append(m)
> > +                if m.name in info.messages_byname:
> > +                    raise Exception("Duplicated message name between %s
> > and %s in channel %s" % (
> > +                        info.messages_byname[m.name].name, m.name,
> > self.name))
> 
> I believe this will repeat twice the same name "between xxx and xxx in
> channel ..". You can only mention the duplicate name once.
> Looks good otherwise.
> 

The exception will stop the program, so only the first is shown

> Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> 
> Christophe
> 

Frediano