[Spice-devel] [PATCH spice-streaming-agent v2] Add name to an unnamed structure

Lukáš Hrázký lhrazky at redhat.com
Thu May 17 16:28:00 UTC 2018


On Thu, 2018-05-17 at 17:21 +0100, Frediano Ziglio wrote:
> Unnamed structure combined with inheritance is considered a
> bit hard to read, add a name to make more readable.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  src/spice-streaming-agent.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Changes since v1:
> - changed the name
> 
> diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
> index 7b166d3..8b0e1dc 100644
> --- a/src/spice-streaming-agent.cpp
> +++ b/src/spice-streaming-agent.cpp
> @@ -126,7 +126,7 @@ static void handle_stream_error(size_t len)
>                                   std::to_string(sizeof(StreamMsgNotifyError)) + ")");
>      }
>  
> -    struct : StreamMsgNotifyError {
> +    struct StreamMsgNotifyError1K : StreamMsgNotifyError {
>          uint8_t msg[1024];
>      } msg;
>  

Acked-by: Lukáš Hrázký <lhrazky at redhat.com>


More information about the Spice-devel mailing list