[Spice-devel] [PATCH spice-common] Add .gitlab-ci.yml file

[Frediano Ziglio]

> 
> On 17/05/18 12:11, Frediano Ziglio wrote:
> >>
> >> Here is an example of a successful run:
> >>
> >> https://gitlab.freedesktop.org/etrunko/spice-common/-/jobs/549
> >>
> > 
> > Stupid question. Is it worth doing giving that spice-common is compiled
> > and tested from both spice-server and spice-gtk?
> > 
> 
> Not a stupid question at all, the main reason for this one is actually
> because meson introduced partial builds of the spice-common code base.
> If we are building server, only server code is generated, while if
> building spice-gtk only client code is generated.
> 

My we need all these libraries and separation? Won't be easier to have
a single library and let the linker do his job?
Protocol file should not be changed that often so code generation and
compile should not be that frequent.
I think would be faster if the python script could generate multiple
files instead of having the parsing done for every file.

> Now, with the introduction of the test-overflow, which depends on both
> server and client marshallers, it is not possible to build this tests
> with neither server or gtk, when using meson.
> 

Ok, the problem is the way currently meson build script works.

> Besides that, I think it will be useful, since we usually push lots of
> patches to spice-common before updating the submodules in spice server
> and spice-gtk. This would enable us to find errors in tests before that
> update happens, although we could definitely use some more tests in
> spice-common. ;)
> 

That make sense!

> Anyway, if you think it is too much hassle, I can force building both
> server and client marshallers with meson for both spice-server and
> spice-gtk.
> 

I personally would prefer to have a single library.

> >> On 17/05/18 11:29, Eduardo Lima (Etrunko) wrote:
> >>> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
> >>> ---
> >>>  .gitlab-ci.yml | 18 ++++++++++++++++++
> >>>  1 file changed, 18 insertions(+)
> >>>  create mode 100644 .gitlab-ci.yml
> >>>
> >>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> >>> new file mode 100644
> >>> index 0000000..1d61805
> >>> --- /dev/null
> >>> +++ b/.gitlab-ci.yml
> >>> @@ -0,0 +1,18 @@
> >>> +image: fedora:latest
> >>> +
> >>> +before_script:
> >>> +  - >
> >>> +    dnf install 'dnf-command(copr)' git libtool make libasan
> >>> +    python3 python3-six python3-pyparsing glib-networking
> >>> +    -y
> >>> +  - dnf copr enable @spice/nightly -y
> >>> +  - dnf builddep spice -y
> >>> +
> >>> +makecheck:
> >>> +  script:
> >>> +  - >
> >>> +    CFLAGS='-O2 -pipe -g -fsanitize=address -fno-omit-frame-pointer
> >>> -Wframe-larger-than=40920'
> >>> +    LDFLAGS='-fsanitize=address -lasan'
> >>> +    ./autogen.sh --enable-extra-checks
> >>> +  - make
> >>> +  - make check || (cat tests/test-suite.log && exit 1)
> >>>
> >>
> > 
> > Frediano
> > 
> 
> 
> --
> Eduardo de Barros Lima (Etrunko)
> Software Engineer - RedHat
> etrunko at redhat.com
>