[Spice-devel] [PATCH spice-common] marshaller: Remove initial underscore from static function

Frediano Ziglio fziglio at redhat.com
Fri May 18 19:09:40 UTC 2018


This is the only function starting with an underscore, looks
out of style.

Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
---
 common/marshaller.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/marshaller.c b/common/marshaller.c
index 80cedb7..b55b568 100644
--- a/common/marshaller.c
+++ b/common/marshaller.c
@@ -270,7 +270,7 @@ static size_t remaining_buffer_size(SpiceMarshallerData *d)
     return MARSHALLER_BUFFER_SIZE - d->current_buffer_position;
 }
 
-static void _reserve_space_free_data(uint8_t *data, SPICE_GNUC_UNUSED void *opaque)
+static void reserve_space_free_data(uint8_t *data, SPICE_GNUC_UNUSED void *opaque)
 {
     free(data);
 }
@@ -313,7 +313,7 @@ uint8_t *spice_marshaller_reserve_space(SpiceMarshaller *m, size_t size)
         /* Large item, allocate by itself */
         item->data = (uint8_t *)spice_malloc(size);
         item->len = size;
-        item->free_data = _reserve_space_free_data;
+        item->free_data = reserve_space_free_data;
         item->opaque = NULL;
     } else {
         /* Use next buffer */
-- 
2.17.0



More information about the Spice-devel mailing list