[Spice-devel] [PATCH spice-gtk] channel-display: Avoid ABI incompatibility for streaming-mode signal

Frediano Ziglio fziglio at redhat.com
Wed May 23 09:44:24 UTC 2018


Changing SpiceDisplayChannelClass structure causes ABI incompatibility.
Having a field for streaming-mode signal is not planned to be used
so remove it.

Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
---
 src/channel-display.c | 4 +---
 src/channel-display.h | 2 --
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/channel-display.c b/src/channel-display.c
index 3f2fb3dc..1c0021e8 100644
--- a/src/channel-display.c
+++ b/src/channel-display.c
@@ -470,9 +470,7 @@ static void spice_display_channel_class_init(SpiceDisplayChannelClass *klass)
     signals[SPICE_DISPLAY_STREAMING_MODE] =
         g_signal_new("streaming-mode",
                      G_OBJECT_CLASS_TYPE(gobject_class),
-                     0,
-                     G_STRUCT_OFFSET(SpiceDisplayChannelClass,
-                                     streaming_mode),
+                     0, 0,
                      NULL, NULL,
                      g_cclosure_user_marshal_POINTER__BOOLEAN,
                      G_TYPE_POINTER,
diff --git a/src/channel-display.h b/src/channel-display.h
index 9c51aa2a..31293094 100644
--- a/src/channel-display.h
+++ b/src/channel-display.h
@@ -141,8 +141,6 @@ struct _SpiceDisplayChannelClass {
                                gint x, gint y, gint w, gint h);
     void (*display_mark)(SpiceChannel *channel,
                          gboolean mark);
-    void (*streaming_mode)(SpiceChannel *channel,
-                           gboolean streaming_mode);
 
     /*< private >*/
 };
-- 
2.17.0



More information about the Spice-devel mailing list