[Spice-devel] [PATCH spice-common v2] Add support for building with meson/ninja

[Jonathon Jongsma]

On Wed, 2018-05-23 at 11:24 -0300, Eduardo Lima (Etrunko) wrote:
> > > 
> > > At the moment spice-common appears to require 2.22. Is there
> > > something
> > > we need from 2.46? If we do need to bump the version, it could
> > > probably
> > > be done in a separate commit from the meson patches?
> > > 
> > 
> > Good question, maybe as now we build spice-common directly too so
> > this was copied from spice-gtk/spice-server?
> > I agree to not bump glib version, at least not in this patch.
> > 
> 
> Building spice-common, actually requires 2.38, because of some
> function
> calls in test-logging, for instance:
> 
> ../tests/test-logging.c: In function ‘test_spice_abort_level’:
> ../tests/test-logging.c:50:5: error: ‘g_test_subprocess’ is
> deprecated:
> Not available before 2.38 [-Werror=deprecated-declarations]
>      if (g_test_subprocess()) {
>      ^~
> In file included from /usr/include/glib-2.0/glib.h:82:0,
>                  from ../tests/test-logging.c:23:
> /usr/include/glib-2.0/glib/gtestutils.h:151:10: note: declared here
>  gboolean g_test_subprocess (void);
>           ^~~~~~~~~~~~~~~~~
> 
> I tried downgrading the requirement to 2.22, but glib errors out
> saying
> that the minimum possible version is 2.26, because of definitions in
> "glib/glibversionmacros.h" file.
> 
> So, it either requires a bump to at least 2.38 or adding workarounds
> in
> test-logging to suppress those messages.
> 
> Additionally, I have added a new 'glib-version' option defaulti to
> specify which version is required, as server and client have
> different
> requirements.

Then we should also bump the requirement in the autotools build. We
could do it in a separate commit before we do the meson patch.

Jonathon