[Spice-devel] [PATCH spice-common] Bump glib requirements to 2.38

Frediano Ziglio fziglio at redhat.com
Wed May 23 20:13:05 UTC 2018


> 
> test-logging makes use of functions only available from this version
> 
> ../tests/test-logging.c: In function ‘test_spice_abort_level’:
> ../tests/test-logging.c:50:5: error: ‘g_test_subprocess’ is deprecated: Not
> available before 2.38 [-Werror=deprecated-declarations]
>      if (g_test_subprocess()) {
>      ^~
> In file included from /usr/include/glib-2.0/glib.h:82:0,
>                  from ../tests/test-logging.c:23:
> /usr/include/glib-2.0/glib/gtestutils.h:151:10: note: declared here
>  gboolean g_test_subprocess (void);
>           ^~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
> ---
>  m4/spice-deps.m4 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/m4/spice-deps.m4 b/m4/spice-deps.m4
> index a6f4b7b..e3ec8be 100644
> --- a/m4/spice-deps.m4
> +++ b/m4/spice-deps.m4
> @@ -158,7 +158,7 @@ AC_DEFUN([SPICE_CHECK_PIXMAN], [
>  # use in the GLIB2_CFLAGS and GLIB2_LIBS variables.
>  #------------------
>  AC_DEFUN([SPICE_CHECK_GLIB2], [
> -    PKG_CHECK_MODULES(GLIB2, glib-2.0 >= 2.22 gio-2.0 >= 2.22 gthread-2.0 >=
> 2.22)
> +    PKG_CHECK_MODULES(GLIB2, glib-2.0 >= 2.38 gio-2.0 >= 2.38 gthread-2.0 >=
> 2.38)
>  ])
>  
>  # SPICE_CHECK_PYTHON_MODULES()

Acked-by: Frediano Ziglio <fziglio at redhat.com>

Note that RHEL6 have only version 2.28.
Weird that this function is used only in spice-common while both spice-server
and spice-gtk do the check manually.
I suppose that's why with Meson the test in spice-common needs a version.

Frediano


More information about the Spice-devel mailing list