[Spice-devel] [vdagent-win PATCH 06/13] file_xfer: Remove FileXferTask structure alignment

Christophe Fergeau cfergeau at redhat.com
Mon May 28 13:04:50 UTC 2018


On Mon, May 28, 2018 at 09:57:59AM +0100, Frediano Ziglio wrote:
> There's no reason beside loosing performances to align
> that structure, is not passed as binary data.

'losing', not 'loosing'

> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  vdagent/file_xfer.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/vdagent/file_xfer.h b/vdagent/file_xfer.h
> index 25cd5c2..029d0e7 100644
> --- a/vdagent/file_xfer.h
> +++ b/vdagent/file_xfer.h
> @@ -21,7 +21,7 @@
>  #include <map>
>  #include "vdcommon.h"
>  
> -typedef struct ALIGN_VC FileXferTask {
> +typedef struct FileXferTask {
>      FileXferTask(HANDLE _handle, uint64_t _size, const TCHAR* _name):
>      handle(_handle), size(_size), pos(0) {
>          // FIXME: should raise an error if name is too long..
> @@ -36,7 +36,7 @@ typedef struct ALIGN_VC FileXferTask {
>      TCHAR name[MAX_PATH];
>  
>      void cancel();
> -} ALIGN_GCC FileXferTask;
> +} FileXferTask;
>  
>  typedef std::map<uint32_t, FileXferTask*> FileXferTasks;
>  
> -- 
> 2.17.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180528/b43925b6/attachment.sig>


More information about the Spice-devel mailing list