[Spice-devel] [vdagent-win PATCH 00/13] Miscellaneous minor patches for the Windows Agent

Christophe Fergeau cfergeau at redhat.com
Mon May 28 13:10:38 UTC 2018


ACK to patches 01 through 07 with the minor comments addressed

Christophe

On Mon, May 28, 2018 at 09:57:53AM +0100, Frediano Ziglio wrote:
> Includes:
> - minor cleanups;
> - project updates;
> - warning removals;
> - possible minor buffer overflows;
> - code style updates.
> 
> Frediano Ziglio (13):
>   vcproj: Remove reference to CxImage
>   vcproj: Add some missing files
>   Fix minor compiler compatibility
>   Avoid unused variable warning
>   msi: Do not generate deps.txt
>   file_xfer: Remove FileXferTask structure alignment
>   file_xfer: Remove too C syntax for C++
>   file_xfer: Use destructor for FileXferTask
>   file_xfer: Use shared_ptr to simplify memory management
>   Minor overflow checks improvements
>   Fix some minor buffer overflows reading registry informations
>   Factor out an utility function to read strings from registry
>   build: Base cmake support
> 
>  CMakeLists.txt                    |  48 ++++++++++++++
>  Makefile.am                       |   8 +--
>  spice-vdagent.wxs.in              |   4 --
>  vdagent/display_configuration.cpp |   2 +-
>  vdagent/display_setting.cpp       | 100 +++++++++++++++++-------------
>  vdagent/file_xfer.cpp             |  48 ++++++--------
>  vdagent/file_xfer.h               |  11 ++--
>  vdagent/image.cpp                 |   4 ++
>  vdagent/vdagent.cpp               |  13 +++-
>  vdagent/vdagent.vcproj            |  28 ++++++---
>  10 files changed, 167 insertions(+), 99 deletions(-)
>  create mode 100644 CMakeLists.txt
> 
> -- 
> 2.17.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180528/58145721/attachment.sig>


More information about the Spice-devel mailing list