[Spice-devel] [PATCH spice-common] test-quic: Fix -Wsign-compare warning

Frediano Ziglio fziglio at redhat.com
Thu May 31 20:44:00 UTC 2018


> 
> ../tests/test-quic.c: In function ‘gdk_pixbuf_new_random’:
> ../tests/test-quic.c:205:19: warning: comparison between signed and unsigned
> integer expressions [-Wsign-compare]
>      for (i = 0; i < gdk_pixbuf_get_byte_length(random_pixbuf); i++) {
>                    ^
> 
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
> ---
>  tests/test-quic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/test-quic.c b/tests/test-quic.c
> index 7ac00f5..2a7ff3d 100644
> --- a/tests/test-quic.c
> +++ b/tests/test-quic.c
> @@ -197,7 +197,7 @@ static GdkPixbuf *gdk_pixbuf_new_random(void)
>      gint width = g_random_int_range(100, 2000);
>      gint height = g_random_int_range(100, 2000);
>      GdkPixbuf *random_pixbuf;
> -    gint i;
> +    guint i;
>      guint8 *pixels;
>  
>      random_pixbuf = gdk_pixbuf_new(GDK_COLORSPACE_RGB, has_alpha, 8, width,
>      height);

Acked, never negative and used for indexing an array.

Frediano


More information about the Spice-devel mailing list