[Spice-devel] [PATCH linux vdagent 1/2] systemd: use "After" with "Requisite"

[Uri Lublin]

On 10/31/18 10:31 PM, Jonathon Jongsma wrote:
> So, I just discovered this year-old patch that (as far as I can tell)
> was never reviewed or pushed upstream. Is anybody willing to review it?

I found it also here:
https://www.freedesktop.org/software/systemd/man/systemd.unit.html

Ack.

Uri.

> 
> Jonathon
> 
> 
> On Wed, 2017-11-29 at 10:44 -0600, Jonathon Jongsma wrote:
>> The "Requisite" directive is intended to require that the virtio port
>> device exists before starting the vdagent socket unit. If the device
>> does not exist, the socket should fail to start. However, without
>> using
>> "After", the socket will still start even when the device is not
>> present.
>>
>> See https://github.com/systemd/systemd/issues/4756 for further
>> details
>> (particularly the following comment:
>> https://github.com/systemd/systemd/issues/4756#issuecomment-267005324
>> )
>>
>> Signed-off-by: Jonathon Jongsma <jjongsma at redhat.com>
>> ---
>>   data/spice-vdagentd.socket | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/data/spice-vdagentd.socket b/data/spice-vdagentd.socket
>> index e34a188..613c7ed 100644
>> --- a/data/spice-vdagentd.socket
>> +++ b/data/spice-vdagentd.socket
>> @@ -2,6 +2,7 @@
>>   Description=Activation socket for spice guest agent daemon
>>   # only start the socket if the virtio port device exists
>>   Requisite=dev-virtio\x2dports-com.redhat.spice.0.device
>> +After=dev-virtio\x2dports-com.redhat.spice.0.device
>>   
>>   [Socket]
>>   ListenStream=/var/run/spice-vdagentd/spice-vdagent-sock
> 
> 
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
>