[Spice-devel] [PATCH spice-server] red-replay-qxl: Remove useless end of line

[Victor Toso]

Hi,

On Fri, Nov 02, 2018 at 09:36:06AM +0000, Frediano Ziglio wrote:
> spice_debug already add a end of line.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/red-replay-qxl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c
> index bd33b581..6958a495 100644
> --- a/server/red-replay-qxl.c
> +++ b/server/red-replay-qxl.c
> @@ -1289,7 +1289,7 @@ static void replay_handle_dev_input(QXLWorker *worker, SpiceReplay *replay,
>          // safe to ignore
>          break;
>      default:
> -        spice_debug("unhandled %d\n", message);
> +        spice_debug("unhandled %d", message);
>      }
>  }
>  
> @@ -1321,7 +1321,7 @@ SPICE_GNUC_VISIBLE QXLCommandExt* spice_replay_next_cmd(SpiceReplay *replay,
>      cmd = replay_malloc0(replay, sizeof(QXLCommandExt));
>      cmd->cmd.type = type;
>      cmd->group_id = 0;
> -    spice_debug("command %"SCNu64", %d\r", timestamp, cmd->cmd.type);
> +    spice_debug("command %"SCNu64", %d", timestamp, cmd->cmd.type);
>      switch (cmd->cmd.type) {
>      case QXL_CMD_DRAW:
>          cmd->flags = 0;

Maybe a few more in the same patch/series? Quick check (not
strictly correct)

 (master 34a44d3e) $ grep -rniI "\\\n" server/*.c | grep -i spice
  server/display-channel.c:2424:        spice_warning("canvas address is %p for %d (and is NULL)\n",
  server/lz4-encoder.c:119:        spice_error("too many lines\n");
  server/memslot.c:64:        spice_warning("virtual address out of range\n"
  server/memslot.c:117:        spice_critical("address generation is not valid, group_id %d, slot_id %d, gen %d, slot_gen %d\n",
  server/red-parse-qxl.c:140:            spice_warning("data split in too many chunks, avoiding DoS\n");
  server/red-parse-qxl.c:170:            spice_warning("too much data inside chunks, avoiding DoS\n");
  server/red-parse-qxl.c:433:        spice_warning("wrong format specified for image\n");
  server/red-parse-qxl.c:440:        spice_warning("image stride too small for width: %d < ((%d * %d + 7) / 8) (%s=%d)\n",
  server/red-parse-qxl.c:489:            spice_warning("guest error: missing palette on bitmap format=%d\n",
  server/red-parse-qxl.c:494:            spice_warning("guest error: zero area bitmap\n");
  server/red-record-qxl.c:835:    static const char header[] = "SPICE_REPLAY 1\n";
  server/red-record-qxl.c:843:        spice_error("failed to open recording file %s\n", filename);
  server/red-replay-qxl.c:1292:        spice_debug("unhandled %d\n", message);
  server/red-replay-qxl.c:1424:    if (fscanf(file, "SPICE_REPLAY %u\n", &version) == 1) {
  server/reds.c:545:        spice_debug("Exiting server because of client disconnect.\n");
  server/reds.c:4358: spice_debug("QXLInterface::client_monitors_config failed\n");

Cheers,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20181116/60395b3a/attachment.sig>