[Spice-devel] [PATCH] x11-randr: Fix typo in error message

Frediano Ziglio fziglio at redhat.com
Fri Nov 16 09:21:31 UTC 2018


> 
> Hi,
> 
> On Thu, Nov 15, 2018 at 10:04:49PM +0000, Frediano Ziglio wrote:
> > The function name is XRRGetScreenSizeRange not RRGetScreenSizeRange.
> > 
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > ---
> >  src/vdagent/x11-randr.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/vdagent/x11-randr.c b/src/vdagent/x11-randr.c
> > index c5fba51..be6a43a 100644
> > --- a/src/vdagent/x11-randr.c
> > +++ b/src/vdagent/x11-randr.c
> > @@ -120,7 +120,7 @@ static void update_randr_res(struct vdagent_x11 *x11,
> > int poll)
> >                                &x11->randr.min_height,
> >                                &x11->randr.max_width,
> >                                &x11->randr.max_height) != 1) {
> > -        syslog(LOG_ERR, "update_randr_res: RRGetScreenSizeRange failed");
> > +        syslog(LOG_ERR, "update_randr_res: XRRGetScreenSizeRange failed");
> 
> That's correct. Out of curiosity, have you seen this error
> message in the logs?
> 

No, I was just looking at the code. It would have been great to understand
where Wayland is failing.

> Acked-by: Victor Toso <victortoso at redhat.com>
> 
> >      }
> >  }
> >  

Frediano


More information about the Spice-devel mailing list