[Spice-devel] [PATCH spice-server 1/2] ci: Merge new glib.supp file

[Frediano Ziglio]

> 
> Hi
> 
> On Fri, Nov 9, 2018 at 2:07 PM Frediano Ziglio <fziglio at redhat.com> wrote:
> >
> > Merge from GLib master repository.
> >
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> 
> Wouldn't it be more robust to refer to the installed version instead?
> (/usr/share/glib-2.0/valgrind/glib.supp on my machine)
> 

I just realized we could pass multiple files! We add some suppressions to
the standard GLib ones (not only GLib leaks memory).
If the path is always the same could be used I suppose. I checked and
Ubuntu (so I suppose Debian) is using the same path however only from 2.56
which would lead to "if system file exists use it if not take this copy".

> > ---
> >  server/tests/valgrind/glib.supp | 54 ++++++++++++++++++++++++++-------
> >  1 file changed, 43 insertions(+), 11 deletions(-)
> >
> > diff --git a/server/tests/valgrind/glib.supp
> > b/server/tests/valgrind/glib.supp
> > index fb2cb4a7..e95f1cb2 100644
> > --- a/server/tests/valgrind/glib.supp
> > +++ b/server/tests/valgrind/glib.supp
> > @@ -17,7 +17,7 @@
> >  # This file should be updated if GLib introduces a new deliberate one-time
> >  leak,
> >  # or another false race positive in Valgrind: please file bugs at:
> >  #
> > -# https://bugzilla.gnome.org/enter_bug.cgi?product=glib
> > +# https://gitlab.gnome.org/GNOME/glib/issues/new
> >
> >  {
> >         gnutls-init-calloc
> > @@ -51,6 +51,36 @@
> >         fun:initialize_module_inlock_reentrant
> >  }
> >
> > +# One-time allocation from libc for getpwnam() results
> > +{
> > +       g-local-vfs-getpwnam
> > +       Memcheck:Leak
> > +       fun:malloc
> > +       ...
> > +       fun:getpwnam
> > +       fun:g_local_vfs_parse_name
> > +}
> > +
> > +{
> > +       glib-init-malloc
> > +       Memcheck:Leak
> > +       fun:malloc
> > +       ...
> > +       fun:g_quark_init
> > +       ...
> > +       fun:glib_init_ctor
> > +}
> > +
> > +{
> > +       glib-init-calloc
> > +       Memcheck:Leak
> > +       fun:calloc
> > +       ...
> > +       fun:g_quark_init
> > +       ...
> > +       fun:glib_init_ctor
> > +}
> > +
> >  {
> >         gobject-init-malloc
> >         Memcheck:Leak
> > @@ -232,6 +262,18 @@
> >         fun:_g_io_module_get_default
> >  }
> >
> > +# One-time getaddrinfo() configuration loading
> > +{
> > +       g-threaded-resolver-getaddrinfo-config
> > +       Memcheck:Leak
> > +       fun:malloc
> > +       ...
> > +       fun:__resolv_conf_allocate
> > +       ...
> > +       fun:getaddrinfo
> > +       fun:do_lookup_by_name
> > +}
> > +
> >  # memcheck checks that the third argument to ioctl() is a valid pointer,
> >  but
> >  # some ioctls use that argument as an integer
> >  {
> > @@ -502,16 +544,6 @@
> >         fun:g_object_new_valist
> >  }
> >
> > -{
> > -       getaddrinfo
> > -       Memcheck:Leak
> > -       fun:malloc
> > -       ...
> > -       fun:__resolv_conf_allocate
> > -       ...
> > -       fun:getaddrinfo
> > -}
> > -
> >  {
> >         px_proxy_factory_get_proxies
> >         Memcheck:Leak

Frediano