[Spice-devel] [PATCH spice-gtk] spice-channel: Add some comment to spice_channel_read

Christophe Fergeau cfergeau at redhat.com
Thu Nov 22 14:32:20 UTC 2018


On Wed, Nov 21, 2018 at 11:24:17AM +0000, Frediano Ziglio wrote:
> Document return value.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  src/spice-channel.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/spice-channel.c b/src/spice-channel.c
> index 1486137e..602869e1 100644
> --- a/src/spice-channel.c
> +++ b/src/spice-channel.c
> @@ -1124,6 +1124,8 @@ static int spice_channel_read_sasl(SpiceChannel *channel, void *data, size_t len
>  
>  /*
>   * Fill the 'data' buffer up with exactly 'len' bytes worth of data
> + * Returns 0 if connection was closed or unknown errors, <0 for error and

"or on unknown errors" I think.

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

Christophe


> + * length on success
>   */
>  /* coroutine context */
>  static int spice_channel_read(SpiceChannel *channel, void *data, size_t length)
> -- 
> 2.17.2
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20181122/370c4ea7/attachment.sig>


More information about the Spice-devel mailing list