[Spice-devel] [PATCH spice-server] dcc: Add debug log when setting compression

Christophe Fergeau cfergeau at redhat.com
Mon Nov 26 13:57:21 UTC 2018


Yup, same patch as the one I had locally (without the submodule update),
thanks, looks good to me.

Christophe

On Mon, Nov 26, 2018 at 01:01:07PM +0000, Frediano Ziglio wrote:
> From: Christophe Fergeau <cfergeau at redhat.com>
> 
> Without this it's not obvious that a compression setting took effect.
> ---
>  server/dcc.c             | 4 ++++
>  subprojects/spice-common | 2 +-
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/server/dcc.c b/server/dcc.c
> index 826dd28f..ae7b4380 100644
> --- a/server/dcc.c
> +++ b/server/dcc.c
> @@ -19,6 +19,7 @@
>  #include <config.h>
>  #endif
>  
> +#include <common/utils.h>
>  #include "dcc-private.h"
>  #include "display-channel.h"
>  #include "display-channel-private.h"
> @@ -1093,6 +1094,9 @@ static bool dcc_handle_preferred_compression(DisplayChannelClient *dcc,
>      default:
>          spice_warning("preferred-compression: unsupported image compression setting");
>      }
> +    g_debug("Setting preferred compression to %s",
> +            spice_genum_get_nick(SPICE_TYPE_SPICE_IMAGE_COMPRESSION_T,
> +                                 dcc->priv->image_compression));
>      return TRUE;
>  }
>  
> diff --git a/subprojects/spice-common b/subprojects/spice-common
> index 2060672e..125cfa7f 160000
> --- a/subprojects/spice-common
> +++ b/subprojects/spice-common
> @@ -1 +1 @@
> -Subproject commit 2060672e8126ed9086dac6b70a4b138c106084a8
> +Subproject commit 125cfa7fb2493060419c79eae3b40dbc499bd3db
> -- 
> 2.17.2
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20181126/296f6686/attachment.sig>


More information about the Spice-devel mailing list