[Spice-devel] [spice-gtk] display-gst: debug instead of warning on lack of video codecs

[Christophe Fergeau]

On Mon, Oct 01, 2018 at 05:43:26PM +0200, Victor Toso wrote:
> From: Victor Toso <me at victortoso.com>
> 
> Just plain ugly to have all Spice clients to warn out several times
> due lack of gstreamer plugins for a given video-codec even though most
> users don't really use streaming at all.

Will there be a warning if they try to use streaming but the video codec
is missing?

Christophe

> 
> Signed-off-by: Victor Toso <victortoso at redhat.com>
> ---
>  src/channel-display-gst.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
> index 3b306c1..73bcbe9 100644
> --- a/src/channel-display-gst.c
> +++ b/src/channel-display-gst.c
> @@ -747,7 +747,8 @@ gboolean gstvideo_has_codec(int codec_type)
>             GST_ELEMENT_FACTORY_TYPE_MEDIA_IMAGE;
>      all_decoders = gst_element_factory_list_get_elements(type, GST_RANK_NONE);
>      if (all_decoders == NULL) {
> -        spice_warning("No video decoders from GStreamer were found");
> +        spice_debug("No video decoders from GStreamer for %s were found",
> +                    gst_opts[codec_type].name);
>          return FALSE;
>      }
>  
> -- 
> 2.17.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20181001/682a40df/attachment.sig>