[Spice-devel] [PATCH spice-common v2] proto: Remove support for SPICE version 1

[Lukáš Hrázký]

On Thu, 2018-10-04 at 07:25 -0400, Frediano Ziglio wrote:
> > On Tue, 2018-10-02 at 11:21 -0400, Frediano Ziglio wrote:
> > > > On Fri, 2018-09-28 at 03:41 -0400, Frediano Ziglio wrote:
> > > > > ping
> > > > 
> > > > Sorry, I was thinking how to handle this and eventually forgot about
> > > > it. Two notes:
> > > > 
> > > > 1. Without really looking into the differences in the protocol, I would
> > > > expect some part of the spice_codegen.py that was specific to the old
> > > > protocol should be removed as well?
> > > > 
> > > 
> > > Yes, sent some follow ups.
> > 
> > Yeah, noticed those after replying here.
> > 
> > > > 2. I think this removal of backwards compatibility should be documented
> > > > somewhere, along with the versions of SPICE server/client with which it
> > > > breaks compatibility. I also think we should use major versions to make
> > > > compatibility breakage obvious.
> > > > 
> > > 
> > > There's the NEWS file which is usually updated before release but it
> > > won't be a bad idea to update it along the way so to not forget and
> > > to avoid the people doing the release to parse all the commit log.
> > > About the major we don't bump much the major... actually is still a 0.XX
> > > version.
> > 
> > Yeah, so I suppose I'm proposing to start using the major number for
> > (at least) this purpose...
> > 
> > Cheers,
> > Lukas
> > 
> 
> As it does not break API/ABI I won't surely bump so version major.
> So you are proposing to bump the "visible" (from user prospective) major
> version (the 0.35). As a user I would ask "what's the big leap in this
> new version after 10 years?". A reply "we removed support for a protocol
> we superseded 10 years ago" does not sound that exiting. On the other
> hand we got Linux 4.x because 30 was a too big number so I suppose is
> just question of opinions.

Yes, I'm talking about the package version, not the ABI (.so) version.
And supposing we continue to remove deprecated old compatibility code.

I think it would be good to explicitly and clearly denote the versions
between which the compatibility was broken, so that users don't need to
wonder and double-check if this and this was introduced in 0.23 or 0.25
and dropped in 0.47 for example...

We could sync the versions of the various components (spice server,
spice-gtk, vd_agent, ...) and make it clear to the user that he needs
to have the same major versions across the board to be compatible.

Otherwise, with the possibility of client, host and guest having very
different OSes and various 0.X versions, the user would have to spend
time studying some compatibility tables (which we don't really have
atm.) or even look up individual features in changelogs (which would be
a nightmare, but it's the current state of things). 

Cheers,
Lukas

> > > > Cheers,
> > > > Lukas
> > > > 
> 
> Frediano