[Spice-devel] [PATCH spice-streaming-agent v2 3/3] Introduce OutboundMessages for the StreamPort class

Lukáš Hrázký lhrazky at redhat.com
Fri Oct 12 11:38:35 UTC 2018


On Fri, 2018-10-12 at 06:50 -0400, Frediano Ziglio wrote:
> > 
> > Heavily based on code by Christophe de Dinechin.
> > 
> > Wraps the serialization code in the OutboundMessage class and its
> > descendants for each specific message. Uses Cruiously Recurring Template
> > Pattern (CRTP) to avoid runtime overhead of polymorphism.
> > 
> > The messages are placed along with the code that sends them, this helps
> > to avoid header proliferation, e.g. the CursorMessage requires X11
> > headers for it's interface.
> > 
> > Signed-off-by: Lukáš Hrázký <lhrazky at redhat.com>
> 
> I cannot apply this patch. I tried to check encodings, apply to different
> commits, ignore whitespaces (all usual stuff) but probably you have a patch
> before this series. I don't want to apply the patch manually (probably also
> easier for you to send an updated version).
> Also I noted that there are long lines (the style limit is 100 columns)
> in this and in minor way in the previous one.

Oh, sorry about that, I've picked up a wrong branch and posted a
different version of the patches :( It's been a long time...

I need to clean up the mess and I'll send v3.

Cheers,
Lukas

> Frediano


More information about the Spice-devel mailing list