[Spice-devel] [QXL PATCH 2/2] Make output names match modsetting driver

Jonathon Jongsma jjongsma at redhat.com
Thu Oct 25 15:36:59 UTC 2018


The xrandr output name used by the QXL driver is based on the drm
connector type, but the names do not match the kernel names (see
/drivers/gpu/drm/drm_connector.c) or the modsetting driver names (see
hw/xfree86/drivers/modesetting/drmmode_display.c). Making these more
consistent will require less driver-specific special-case code if a user
wants to match an xrandr output to a drm connector.

Note that this patch should not actually change any behavior, since the
QXL driver only uses the 'Virtual' connector type, so this is done only
for consistency.

Signed-off-by: Jonathon Jongsma <jjongsma at redhat.com>
---
 src/qxl_drmmode.c | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/src/qxl_drmmode.c b/src/qxl_drmmode.c
index a814859..0f95499 100644
--- a/src/qxl_drmmode.c
+++ b/src/qxl_drmmode.c
@@ -722,20 +722,22 @@ static int subpixel_conv_table[7] = { 0, SubPixelUnknown,
 
 const char *output_names[] = { "None",
 			       "VGA",
-			       "DVI",
-			       "DVI",
-			       "DVI",
+			       "DVI-I",
+			       "DVI-D",
+			       "DVI-A",
 			       "Composite",
-			       "S-video",
+			       "SVIDEO",
 			       "LVDS",
-			       "CTV",
+			       "Component",
 			       "DIN",
-			       "DisplayPort",
-			       "HDMI",
+			       "DP",
 			       "HDMI",
+			       "HDMI-B",
 			       "TV",
 			       "eDP",
-			       "Virtual"
+			       "Virtual",
+			       "DSI",
+			       "DPI",
 };
 
 static void
-- 
2.17.2



More information about the Spice-devel mailing list