[Spice-devel] [PATCH spice-gtk] meson: Fix usage of add_project_arguments()
Frediano Ziglio
fziglio at redhat.com
Mon Sep 3 13:58:05 UTC 2018
>
> This function does accept a list of arguments, so there is no need to
> iterate over it.
>
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
Acked-by: Frediano Ziglio <fziglio at redhat.com>
But I'd like to see CI fixes merged before this one.
I cannot understand why "meson test" fails, Meson fails with
a weird Python stack trace and nothing in the logs.
If I comment out usb-acl-helper test (tests/meson.build) CI
and manual Meson build succeed.
Frediano
> ---
> meson.build | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index f893733..cf01abf 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -387,9 +387,8 @@ if spice_gtk_has_gtk
> '-DGDK_VERSION_MAX_ALLOWED=@0@'.format(gtk_encoded_version)]
> endif
>
> -foreach arg : compiler.get_supported_arguments(spice_gtk_global_cflags)
> - add_project_arguments(arg, language : 'c')
> -endforeach
> +add_project_arguments(compiler.get_supported_arguments(spice_gtk_global_cflags),
> + language : 'c')
>
> #
> # Subdirectories
More information about the Spice-devel
mailing list