[Spice-devel] [spice-gtk v1 0/4] usbredir on failing to switch to tls

Victor Toso victortoso at redhat.com
Thu Sep 6 14:13:09 UTC 2018


From: Victor Toso <me at victortoso.com>

Hi,

This is about bug: https://bugzilla.redhat.com/show_bug.cgi?id=1625550

The channel-usbredir is doing something a bit dangerous by channel-reset
async but it does seem fine overal. Considering the machine states, it
would be great to have different testing scenarios while
migrating/reconnecting but that's a bit hard at the moment.

The first two patches are handling the UI part, the failure of
channel_connect() should be handled as the client are not able to
redirect any USB device. The third patch is more about documentation and
I welcome if any one has anything to add/remove/change there.

The bug itself happens when priv->host exists but
priv->state != STATE_CONNECTED. That path does not chain-up with
spice-channel's channel_reset()

Cheers,
Victor

Victor Toso (4):
  spice-channel: Properly error out if reconnect fails
  usb-device-manager: Handle connectionless channel
  channel-usbredir: Add FIXMEs on channel-reset issues
  channel-usbredir: Chain-up with parent's channel-reset

 src/channel-usbredir.c   | 34 ++++++++++++++++++++++------------
 src/spice-channel.c      |  8 ++++++--
 src/usb-device-manager.c | 31 +++++++++++++++++++++++++++++++
 3 files changed, 59 insertions(+), 14 deletions(-)

-- 
2.17.1



More information about the Spice-devel mailing list