[Spice-devel] [spice-gtk v4 00/13] CD sharing feature

[Yuri Benditovich]

On Mon, Sep 24, 2018 at 4:32 PM Christophe Fergeau <cfergeau at redhat.com>
wrote:

> On Sat, Sep 22, 2018 at 12:21:04AM +0300, Yuri Benditovich wrote:
> > On Sat, Sep 22, 2018 at 12:14 AM, Yuri Benditovich <
> > yuri.benditovich at daynix.com> wrote:
> >
> > > Hi
> > >
> > > On Fri, Sep 21, 2018 at 9:10 PM, Christophe Fergeau <
> cfergeau at redhat.com>
> > > wrote:
> > >
> > >> On Mon, Sep 17, 2018 at 04:22:50PM +0300, Yuri Benditovich wrote:
> > >> > Changes from v3:
> > >> > Single commit with all new files split to 12 patches
> > >> > to make patch review easier
> > >>
> > >> What you did is not splitting at all, adding one new file per commit,
> > >> and then all the modifications to the existing code in a final commit
> > >> is not what we meant when we asked for split patches.
> > >>
> > >> You asked why this is needed, and actually, it turns out your patches
> > >> introduce a regression in virt-viewer even when not exercising at all
> > >> any of the new code. The series as it is is not bisectable in any way,
> > >> so I basically have to look at these 9000 lines of code to try to
> figure
> > >> out what broke...
> > >>
> > >
> > BTW I'm sorry to write it, but for the record the patch is not 9000
> lines,
> > if is less than 2500 lines including all.
>
> cd-scsi.c itself which I assume to be new code is 2700 lines, the new
> widget is 2000 lines, usb-backend-common.c is 2000 lines. I'm taking the
> 9000 lines figure from your cover letter by the way..
>
> https://lists.freedesktop.org/archives/spice-devel/2018-September/045576.html
>  26 files changed, 9321 insertions(+), 520 deletions(-)
>
>
> > I believe if you describe the kind of regression I am able to find root
> > cause of it quickly.
>
> I'm sure you can, but if you are the only one who can do that, that's a
> maintainance concern. The issue is most likely caused by a leak of the
> usb channel (or a leak from it). Start latest virt-viewer to connect to
> a VM (probably with USB redir channels configured), exit it, and see it
> hangs.
>
>
Exit viewer or exit VM?
Usually I the test with built-in remote-viewer, running it from .libs
directory
with LD_LIBRARY_PATH=.

Nothing hangs.

Let's take it to separate mail thread, may be? Or all this process must be
piblic and here?


> Christophe
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180924/af401357/attachment.html>