[Spice-devel] [PATCH spice-gtk] gitabl-ci: fix CI build

[Victor Toso]

Hi,

On Tue, Sep 25, 2018 at 04:58:39AM -0400, Frediano Ziglio wrote:
> > Hi,
> > 
> > On Tue, Sep 25, 2018 at 04:17:50AM -0400, Frediano Ziglio wrote:
> > > > 
> > > > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> > > > 
> > > > I broke gitlab CI in commit f61534d by introducing json-glib
> > > > dependency. Instead of depending on dnf builddep, list the build
> > > > dependencies explicitly.
> > > > 
> > > > Remove copr usage, that fails from time to time. Install
> > > > spice-protocol from git.
> > > > 
> > > > Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> > > > ---
> > > >  .gitlab-ci.yml | 16 +++++++++++-----
> > > >  1 file changed, 11 insertions(+), 5 deletions(-)
> > > > 
> > > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > > > index e5e90af..7cd26d3 100644
> > > > --- a/.gitlab-ci.yml
> > > > +++ b/.gitlab-ci.yml
> > > > @@ -2,11 +2,17 @@ image: fedora:latest
> > > >  
> > > >  before_script:
> > > >    - >
> > > > -    dnf install 'dnf-command(copr)' git libtool make redhat-rpm-config
> > > > -    python3 python3-six python3-pyparsing meson ninja-build
> > > > -    -y
> > > > -  - dnf copr enable @spice/nightly -y
> > > > -  - dnf builddep spice-gtk -y
> > > > +    dnf install -y git libtool make python3 python3-six
> > > > +    redhat-rpm-config python3-pyparsing meson ninja-build zlib-devel
> > > > +    openssl-devel intltool gtk3-devel gtk-doc
> > > > +    gobject-introspection-devel cyrus-sasl-devel pulseaudio-libs-devel
> > > > +    libjpeg-turbo-devel libacl-devel gstreamer1-devel
> > > > +    gstreamer1-plugins-base-devel polkit-devel vala lz4-devel
> > > > +    opus-devel libgudev-devel pixman-devel libcacard-devel
> > > > +    celt051-devel libphodav-devel usbutils usbredir-devel libusbx-devel
> > > > +    libsoup-devel spice-protocol json-glib-devel
> > > > +  - git clone https://gitlab.freedesktop.org/spice/spice-protocol
> > > > +  - (cd spice-protocol && ./autogen.sh --prefix=/usr && make install)
> > > > 
> > > 
> > > Why do you install spice-protocol twice (from package and manually) ?
> > 
> > Good catch
> > 
> > > Is there a way to use a "relative" url in git clone? Maybe using
> > > CI_REPOSITORY_URL variable? Like (didn't test, bash)
> > > 
> > >    got clone ${CI_REPOSITORY_URL//spice-gtk/spice-protocol}
> > 
> > I guess you would like to have the CI to run against the
> > person's local repo? i.e: the spice-gtk ci for freddy would fetch
> > spice-protocol from freddy as well? or is there any other reason?
> > 
 
> Yes, mainly for this reason.
> Also if tomorrow gitlab changes their URLs schema or if you move
> hosting will continue to work.

Ok

> > > >  makecheck:
> > > >    script:
> 
> CI is passing, see https://gitlab.freedesktop.org/fziglio/spice-gtk/pipelines/4812.
> 
> I would say ack.

Yep, me too (if I didn't before)
Acked-by: Victor Toso <victortoso at redhat.com>

> 
> Frediano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180925/5ce4c6a4/attachment.sig>