[Spice-devel] [PATCH spice-gtk] gitabl-ci: fix CI build

[Marc-André Lureau]

Hi

On Tue, Sep 25, 2018 at 5:47 PM Eduardo Lima (Etrunko)
<etrunko at redhat.com> wrote:
>
> On 9/24/18 6:04 PM, marcandre.lureau at redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> >
> > I broke gitlab CI in commit f61534d by introducing json-glib
> > dependency. Instead of depending on dnf builddep, list the build
> > dependencies explicitly.
> >
> > Remove copr usage, that fails from time to time. Install
> > spice-protocol from git.
> >
>
> I think it would be interesting to keep installing packages from copr,
> maybe in a separate task, as it gives us some overview about the
> packaging. As an example, now that you added explicit dependency on
> json-glib in your previous commit, shouldn't it be added to
> spice-gtk.spec as well? As far as I remember, copr uses the scripts
> written by Pavel, and the repository is/was
> https://gitlab.com/xerus/copr-build-helper/

I was not aware of how the nightly builds were handled, is it still
running and managed by Pavel.
Imho it's up to the maintainer of the spec to fix the builddeps.

Copr has apparently ways to hook commits from a repository (the
upstream repo) to trigger rpm builds (from dist-git). It seems custom
build rules could clone the upstream source, and modify the spec,
before doing a snapshot build. This requires some research, I don't
know anyone using that method, but that could simplify the handling of
nightly builds (avoiding the script, cron job, duplication of spec
etc).


--
Marc-André Lureau