[Spice-devel] [PATCH spice-server 1/2] Bump meson requirement to 0.47.2

Christophe Fergeau cfergeau at redhat.com
Wed Sep 26 08:25:56 UTC 2018


NB: The newer meson we require, the harder it will be to say "ok, from
now on, we'll be switching to building with meson by default".

Christophe

On Tue, Sep 25, 2018 at 02:40:00PM -0300, Eduardo Lima (Etrunko) wrote:
> This new version ships the fix for the issue where 'check' keyword could
> not be used in project definition, so we had to run that command again
> only to check if it succeeded.
> 
> https://github.com/mesonbuild/meson/issues/3944
> 
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
> ---
>  meson.build | 13 ++-----------
>  1 file changed, 2 insertions(+), 11 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 762f1d1c..3184a6f5 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2,22 +2,13 @@
>  # project definition
>  #
>  project('spice', 'c',
> -        version : run_command('build-aux/git-version-gen', '${MESON_SOURCE_ROOT}/.tarball-version').stdout().strip(),
> +        version : run_command('build-aux/git-version-gen', '${MESON_SOURCE_ROOT}/.tarball-version', check : true).stdout().strip(),
>          license : 'LGPLv2.1',
> -        meson_version : '>= 0.47.0')
> -
> -# double check meson.project_version()
> -# we can not use 'check' keyword in run_command() for git-version-gen above
> -# https://github.com/mesonbuild/meson/issues/3944
> -version = run_command('build-aux/git-version-gen', '${MESON_SOURCE_ROOT}/.tarball-version', check : true).stdout().strip()
> -if meson.project_version() != version
> -  error('Wrong project version')
> -endif
> +        meson_version : '>= 0.47.2')
>  
>  message('Updating submodules')
>  run_command('build-aux/meson/check-spice-common', check : true)
>  
> -
>  #
>  # soversion
>  # The versioning is defined by the forumla (CURRENT-AGE.AGE.REVISION)
> -- 
> 2.17.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180926/a3977bda/attachment.sig>


More information about the Spice-devel mailing list