[Spice-devel] [PATCH spice-gtk 4/5] meson: Add json-glib to the list of mandatory deps

[Eduardo Lima (Etrunko)]

On 9/26/18 5:26 AM, Frediano Ziglio wrote:
>>
>> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
>> ---
>>  meson.build | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/meson.build b/meson.build
>> index 629f109..ebd42e1 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -88,10 +88,9 @@ foreach dep, version : deps
>>    spice_gtk_deps += dependency(dep, version : version)
>>  endforeach
>>  
>> -spice_gtk_deps += dependency('json-glib-1.0')
>> -
>> +# mandatory dependencies, without specific version requirement
>>  # TODO: specify minimum version for cairo, jpeg and zlib?
>> -deps = ['cairo', 'libjpeg', 'zlib']
>> +deps = ['cairo', 'libjpeg', 'zlib', 'json-glib-1.0']
> 
> Acked-by: Frediano Ziglio <fziglio at redhat.com>
> 
>>  if spice_gtk_host_system == 'windows'
>>    deps += 'gio-windows-2.0'
>>  else
> 
> OT: Mumble... this make me wonder... maybe we could integrate the
> Gitlab CI with a MingW (cross Windows) build?
> 

Definitely something worth trying. I still have not done a cross build
with meson, but from the documentation it should not be difficult.

> Frediano
> 


-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com