[Spice-devel] [spice-gtk v1 2/2] usb-redirection: use usb backend for usb redirection

Christophe Fergeau cfergeau at redhat.com
Fri Sep 28 09:33:34 UTC 2018


On Fri, Sep 28, 2018 at 12:26:09PM +0300, Yuri Benditovich wrote:
> > > diff --git a/src/meson.build b/src/meson.build
> > > index 8c9199e..2870102 100644
> > > --- a/src/meson.build
> > > +++ b/src/meson.build
> > > @@ -78,6 +78,7 @@ spice_client_glib_introspection_sources = [
> > >    'spice-session.c',
> > >    'spice-util.c',
> > >    'usb-device-manager.c',
> > > +  'usb-backend-common.c',
> >
> > I think you also need usb-backend.h in this file.
> >
> 
> 'backend.h' is not public. If it is included into 'introspection' it seems
> that this requires inline documentation for some small subset of procedures
> (not sure how they are selected).
> What is the documenting policy for non-public headers?

Oh, shouldn't both the c file and h file go to spice_client_glib_sources
rather than spice_client_glib_introspection_sources?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180928/1da83e05/attachment.sig>


More information about the Spice-devel mailing list