[Spice-devel] [PATCH spice-common] build: Add new check for recorder library

Frediano Ziglio fziglio at redhat.com
Wed Apr 3 08:34:24 UTC 2019


> 
> Hi,
> 
> On Tue, Apr 02, 2019 at 01:49:06PM +0100, Frediano Ziglio wrote:
> > Newer version try to use this function if available.
> 
> So it should be checked if recorder is enabled, no?
> That's on stdio.h so I can't really see why not anyway
> 

Not for MingW (implementation reasons) and it's not C standard.

> Acked-by: Victor Toso <victortoso at redhat.com>
> 

Thanks,
  Frediano

> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > ---
> >  configure.ac | 2 +-
> >  meson.build  | 3 ++-
> >  2 files changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index 923055b..da0a687 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -27,7 +27,7 @@ fi
> >  AM_PROG_CC_C_O
> >  
> >  AC_CHECK_HEADERS([sys/mman.h regex.h])
> > -AC_CHECK_FUNCS([sigaction drand48])
> > +AC_CHECK_FUNCS([sigaction drand48 setlinebuf])
> >  AC_SEARCH_LIBS(regcomp, [regex rx])
> >  
> >  SPICE_CHECK_SYSDEPS
> > diff --git a/meson.build b/meson.build
> > index f69e4bc..0faf703 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -78,7 +78,8 @@ endforeach
> >  #
> >  functions = ['alloca',
> >               'sigaction',
> > -             'drand48']
> > +             'drand48',
> > +             'setlinebuf']
> >  
> >  foreach func : functions
> >    if compiler.has_function(func)


More information about the Spice-devel mailing list