[Spice-devel] [PATCH] Unify openssl checks

[Roman Bogorodskiy]

  Frediano Ziglio wrote:

> > 
> > Currently, spice-gtk uses PKG_CHECK_MODULES(SSL, openssl) to detect
> > openssl CFLAGS and LIBS. And spice-common defines and uses
> > SPICE_CHECK_OPENSSL macro which calls
> > PKG_CHECK_MODULES(OPENSSL, openssl).
> > 
> > This means that in order to override openssl CFLAGS or LIBS a user will
> > have to set both OPENSSL_(CFLAGS|LIBS) and SSL_(CFLAGS|LIBS).
> > 
> > To make this more consistent, make spice-gtk use the
> > SPICE_CHECK_OPENSSL macro from spice-common.
> > 
> > Signed-off-by: Roman Bogorodskiy <bogorodskiy at gmail.com>
> 
> In configure.ac there's an usage of SSL_CFLAGS:
> 
> SPICE_GLIB_CFLAGS="$PIXMAN_CFLAGS $PULSE_CFLAGS $GSTAUDIO_CFLAGS $GSTVIDEO_CFLAGS $GLIB2_CFLAGS $GIO_CFLAGS $GOBJECT2_CFLAGS $SSL_CFLAGS $SASL_CFLAGS"
> 
> should be replaced
> 
> Frediano

Indeed, thanks, fixed in v2.

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190427/4e34b45f/attachment.sig>