[Spice-devel] [PATCH] gitlab-ci: build out-of-tree too

[Uri Lublin]

On 4/30/19 1:15 PM, Frediano Ziglio wrote:
> This is for SPICE server (missing in the subject).

Yes, sorry.

> 
>>
>> Signed-off-by: Uri Lublin <uril at redhat.com>
>> ---
>>
>> The relevant job of the pipeline is:
>> https://gitlab.freedesktop.org/uril/spice/-/jobs/269735
>>
>> ---
>>   .gitlab-ci.yml | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index 9ce95c00e..43cdb45ac 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -14,12 +14,15 @@ before_script:
>>   
>>   makecheck:
>>     script:
>> +  - mkdir builddir
> 
> I would put a comment before this "mkdir" like in spice-gtk.
> Other tests (IMHO correctly) run also in-tree so both conditions
> are tested.

OK. I'll send a V2.

Thanks,
     Uri.

> 
>> +  - cd builddir
>>     - >
>>       CFLAGS='-O2 -pipe -g -fsanitize=address -fno-omit-frame-pointer
>>       -Wframe-larger-than=40920'
>>       LDFLAGS='-fsanitize=address -lasan'
>> -    ./autogen.sh --enable-celt051
>> +    ../autogen.sh --enable-celt051
>>     - make
>>     - make -C server check || (cat server/tests/test-suite.log && exit 1)
>> +  - cd ..
>>   
>>   meson-makecheck:
>>     script:
> 
> Otherwise fine with it.
> 
> Frediano
>