[Spice-devel] [PATCH spice-server 01/13] char-device: Remove unused red_char_device_destroy function

[Victor Toso]

Hi,

There still is some comments for this function call, I'd update
it here as well if it makes sense to do so

    server/char-device.h:94: * device detached: call red_char_device_destroy/reset
    server/char-device.h:123: * case red_char_device_destroy has been called

Still,
Acked-by: Victor Toso <victortoso at redhat.com>

On Thu, May 30, 2019 at 03:22:42PM +0100, Frediano Ziglio wrote:
> g_object_unref is directly used.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/char-device.c | 6 ------
>  server/char-device.h | 1 -
>  2 files changed, 7 deletions(-)
> 
> diff --git a/server/char-device.c b/server/char-device.c
> index 9ee255664..0f6a29d6f 100644
> --- a/server/char-device.c
> +++ b/server/char-device.c
> @@ -697,12 +697,6 @@ void red_char_device_reset_dev_instance(RedCharDevice *dev,
>      g_object_notify(G_OBJECT(dev), "sin");
>  }
>  
> -void red_char_device_destroy(RedCharDevice *char_dev)
> -{
> -    g_return_if_fail(RED_IS_CHAR_DEVICE(char_dev));
> -    g_object_unref(char_dev);
> -}
> -
>  static RedCharDeviceClient *red_char_device_client_new(RedClient *client,
>                                                         int do_flow_control,
>                                                         uint32_t max_send_queue_size,
> diff --git a/server/char-device.h b/server/char-device.h
> index 893d3e4b1..7d3ad8b3a 100644
> --- a/server/char-device.h
> +++ b/server/char-device.h
> @@ -160,7 +160,6 @@ typedef struct RedCharDeviceWriteBuffer {
>  
>  void red_char_device_reset_dev_instance(RedCharDevice *dev,
>                                          SpiceCharDeviceInstance *sin);
> -void red_char_device_destroy(RedCharDevice *dev);
>  
>  /* only one client is supported */
>  void red_char_device_migrate_data_marshall(RedCharDevice *dev,
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190802/f0fdc1a0/attachment.sig>