[Spice-devel] [PATCH spice-streaming-agent 1/4] gst-plugin: Allow ANY memory type to pass from convertor to encoder

Frediano Ziglio fziglio at redhat.com
Tue Aug 6 11:59:43 UTC 2019


Minor: typo in subject "convertor" -> "converter".

Otherwise,
  Acked.

It would be even better to state that this allow for example VASurface type.

Frediano

> 
> ---
>  src/gst-plugin.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gst-plugin.cpp b/src/gst-plugin.cpp
> index 6415ac0..e9d9364 100644
> --- a/src/gst-plugin.cpp
> +++ b/src/gst-plugin.cpp
> @@ -252,7 +252,7 @@ void GstreamerFrameCapture::pipeline_init(const
> GstreamerEncoderSettings &settin
>      gst_bin_add(bin, encoder);
>      gst_bin_add(bin, sink);
>  
> -    GstCapsUPtr caps(gst_caps_from_string("video/x-raw"));
> +    GstCapsUPtr caps(gst_caps_from_string("video/x-raw(ANY)"));
>      link = gst_element_link(capture.get(), convert.get()) &&
>             gst_element_link_filtered(convert.get(), encoder.get(),
>             caps.get()) &&
>             gst_element_link_filtered(encoder.get(), sink.get(),
>             sink_caps.get());



More information about the Spice-devel mailing list